Re: CVS commit: src/sys/dev/wsfb

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

On 2020/10/18 21:18, Jared McNeill wrote:
> I think WSFB_VRAM_IS_RAM is meant to be a hint for what kind of memory you get when you mmap the device. When shadow FB is used, that is generally only used for rasops and mmap bypasses the shadow and uses device memory directly. So I think this could cause performance regressions on such hardware where shadow FB is enabled and reading VRAM is slow.
>
> What problem are you attempting to solve with this change?

Ah, I misunderstood its intention. I will revert this commit.
Thank you for pointing out!

PS
I came across this flag bit when I was examining byte-order problems
of framebuffer on aarch64eb. I'm just going to send a message to you.
I will soon!

Thanks,
rin