Re: CVS commit: src/sys/dev/wsfb

[Jared McNeill <jmcneill%invisible.ca@localhost>]

I think WSFB_VRAM_IS_RAM is meant to be a hint for what kind of memory you 
get when you mmap the device. When shadow FB is used, that is generally 
only used for rasops and mmap bypasses the shadow and uses device memory 
directly. So I think this could cause performance regressions on such 
hardware where shadow FB is enabled and reading VRAM is slow.

What problem are you attempting to solve with this change?


On Sun, 18 Oct 2020, Rin Okuyama wrote:

> Module Name:	src
> Committed By:	rin
> Date:		Sun Oct 18 11:54:21 UTC 2020
>
> Modified Files:
> 	src/sys/dev/wsfb: genfb.c
>
> Log Message:
> For WSDISPLAYIO_GET_FBINFO ioctl, set WSFB_VRAM_IS_RAM to fbi_flags
> when shadow FB is used.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.74 -r1.75 src/sys/dev/wsfb/genfb.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.