Re: CVS commit: src/sys

[Robert Swindells <rjs%fdy2.co.uk@localhost>]

matthew green <mrg%eterna.com.au@localhost> wrote:
>however, i'm looking at the changes and i'm not 100% convinced
>it's safe to simply replace this file as-is.
>
> - struct v4l2_pix_format is laid out differently
> - enum v4l2_buf_type <-> u_int32_t does not seem safe, in
>   eg struct v4l2_buffer.  i *think* it may be, but it won't
>   work with eg, -fshort-enums now.
> - struct v4l2_rect width/height are now unsigned (probably ok?)
> - struct v4l2_window has a new member (global_alpha)

Both v4l2_pix_format and v4l2_window are used in a union that is
padded to 200 bytes.

Where does -fshort-enums get used ? It looks to me that it would have
broken alignment of other struct members if it had been defined.