Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys



matthew green writes:
> > also, these updates to video(4) don't require a kernel bump
> > so please revert that too.
> 
> but this part could be done if you do it fast..

uvideo(4) as a module proves me wrong about this one too..

however, i'm looking at the changes and i'm not 100% convinced
it's safe to simply replace this file as-is.

 - struct v4l2_pix_format is laid out differently
 - enum v4l2_buf_type <-> u_int32_t does not seem safe, in
   eg struct v4l2_buffer.  i *think* it may be, but it won't
   work with eg, -fshort-enums now.
 - struct v4l2_rect width/height are now unsigned (probably ok?)
 - struct v4l2_window has a new member (global_alpha)

... this is enough for you to need to look at all of these
closely to ensure you haven't broken binary compat.  please look
at all the structure layouts and ensure they aren't changed.

thanks.


.mrg.


Home | Main Index | Thread Index | Old Index