Re: CVS commit: src/sys/arch/evbarm/conf

[Jason Thorpe <thorpej%me.com@localhost>]

> On Aug 18, 2018, at 8:49 AM, Rin Okuyama <rokuyama%rk.phys.keio.ac.jp@localhost> wrote:
> 
> On 2018/08/19 0:06, Jason Thorpe wrote:
>>> On 2018/08/18 20:08, Rin Okuyama wrote:
>>>> Ah, then it should be "if ARM32". It was "if arm32" in rev. 1.31.
>>> 
>>> Sorry, not 1.31 but 1.30.
>> That's because all options are normalized to lower-case.
> 
> Oops, not "if" but "ifdef".
> 
> "ifdef" statements refer "attrtab", whose entries are not normalized to
> lower-case. Therefore, "ifdef arm32" becomes false even if we have
> "options ARM32", as I wrote in the previous message:
> 
> http://mail-index.netbsd.org/source-changes-d/2018/08/18/msg010463.html
> 
> Well, this is a very confusing behavior of config(1). We should normalize
> everything to lower-case, provided no one depends on this behavior...

Well, interestingly enough, this works (of course):

# files common to arm32 implementations
file    arch/arm/arm32/arm32_machdep.c          arm32
file    arch/arm/arm32/bus_dma.c                arm32
.
.
.

I'm a little confused why "ifdef" would reference the attrtab, though...it seems like it should be looking at the options / flags table.  (It's been a long time since I was deep in the bowels of config(1), though, so entirely possible that something drastic has changed while I wasn't paying attention...)

-- thorpej