Re: CVS commit: src/sys/arch/evbarm/conf

[Rin Okuyama <rokuyama%rk.phys.keio.ac.jp@localhost>]

On 2018/08/18 22:41, Jared McNeill wrote:
> Not sure I understand this change. arm32 should be defined on 32-bit evbarm platforms via std.evbarm.
>
> If arm32 is not defined, I wouldn't expect a kernel to link as there are dependencies on it in arch/arm/conf/files.arm as well.

No "arm32" is not defined.

arch/arm/conf/files.arm is included because of "machine evbarm arm" lines in
std.* files for 32bit machines. On the other hand, for 64bit machines,
arch/aarch64/conf/files.aarch64 is used because of "machine evbarm aarch64".

Actually, with files.evbarm rev 1.30, we observe

	% ktrace config RPI2 && kdump | grep NAMI | grep 'majors\.'
	Build directory is ../compile/RPI2
	Don't forget to run "make depend"
	 21972      1 config   NAMI  "../../../../arch/aarch64/conf/majors.aarch64"

On the other hand, with files.evbarm rev 1.31, we have

	% ktrace config RPI2 && kdump | grep NAMI | grep 'majors\.'
	Build directory is ../compile/RPI2
	Don't forget to run "make depend"
	  6856      1 config   NAMI  "../../../../arch/arm/conf/majors.arm32"

> On Sat, 18 Aug 2018, Rin Okuyama wrote:
>
> > Module Name:    src
> > Committed By:    rin
> > Date:        Sat Aug 18 09:29:45 UTC 2018
> >
> > Modified Files:
> >     src/sys/arch/evbarm/conf: files.evbarm
> >
> > Log Message:
> > Fix a bug introduced in the previous revision;
> > We don't define arm32 anywhere, and majors.aarch64 is used unconditionally.
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.30 -r1.31 src/sys/arch/evbarm/conf/files.evbarm
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.