Re: CVS commit: src/sys/arch/ia64/ia64

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

KIYOHARA Takashi wrote:
> Module Name:  src
> Committed By: kiyohara
> Date:         Mon Jul 20 05:10:49 UTC 2009
> 
> Modified Files:
>       src/sys/arch/ia64/ia64: machdep.c mainbus.c
> 
> Log Message:
> Fix little bit, and add a few files.
>   current status is to see following thread.
>     http://mail-index.netbsd.org/port-ia64/2009/06/18/msg000102.html
> Also call banner().

[...]

> -int  mainbus_match(struct device *, struct cfdata *, void *);
> -void mainbus_attach(struct device *, struct device *, void *);
> +#include <machine/bus.h>

Shouldn't new code use <sys/bus.h> ?

> -CFATTACH_DECL(mainbus, sizeof(struct device),
> +#include <dev/acpi/acpivar.h>
> +
> +
> +static int mainbus_match(struct device *, struct cfdata *, void *);
> +static void mainbus_attach(struct device *, struct device *, void *);
> +
> +CFATTACH_DECL_NEW(mainbus, sizeof(struct device),
>      mainbus_match, mainbus_attach, NULL, NULL);

I think, this should be

CFATTACH_DECL_NEW(mainbus, 0,
    mainbus_match, mainbus_attach, NULL, NULL);

Christoph