Re: GNU vs C99 extern inline

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

Iain Hibbert <plunky%rya-online.net@localhost> wrote:
> Index: x86/pmap.c
> ===================================================================
> RCS file: /cvsroot/src/sys/arch/x86/x86/pmap.c,v
> retrieving revision 1.118
> diff -u -r1.118 pmap.c
> --- x86/pmap.c        11 Feb 2011 23:08:38 -0000      1.118
> +++ x86/pmap.c        19 Apr 2011 10:38:26 -0000
> @@ -764,17 +764,6 @@
>  }
> 
>  /*
> - *   Add a reference to the specified pmap.
> - */
> -
> -inline void
> -pmap_reference(struct pmap *pmap)
> -{
> -
> -     atomic_inc_uint(&pmap->pm_obj[0].uo_refs);
> -}
> -
> -/*
>   * pmap_map_ptes: map a pmap's PTEs into KVM and lock them in
>   *
>   * => we lock enough pmaps to keep things locked in

Not worth.  Please just drop inline and leave as a function.

Thanks.

-- 
Mindaugas