Re: Adding 'i386_use_pae' variable, and expose it through sysctl

[Alan Barrett <apb%cequrux.com@localhost>]

On Sun, 15 Aug 2010, Joerg Sonnenberger wrote:
> Just use dynamic sysctls, please. No reason to wire down the OID.

It might make sense to add comments near all existing lists of
hard-wired sysctl OID values asking people not to add more of them.

--apb (Alan Barrett)

Index: arch/x86/include/cpu.h
--- arch/x86/include/cpu.h      24 Jul 2010 00:45:56 -0000      1.23
+++ arch/x86/include/cpu.h      15 Aug 2010 12:02:26 -0000
@@ -439,7 +439,9 @@ void x86_bus_space_mallocok(void);
 #endif /* _KERNEL || _STANDALONE */
 
 /*
- * CTL_MACHDEP definitions.
+ * CTL_MACHDEP definitions, for sysctl nodes that pre-date the
+ * availability of the dynamic sysctl(9) interface.  New sysctl nodes
+ * should use CTL_CREATE instead of adding new definitions here.
  */
 #define        CPU_CONSDEV             1       /* dev_t: console terminal 
device */
 #define        CPU_BIOSBASEMEM         2       /* int: bios-reported base mem 
(K) */
@@ -462,6 +464,7 @@ void x86_bus_space_mallocok(void);
 #define        CPU_TMLR_VOLTAGE        13      /* int: curret voltage */
 #define        CPU_TMLR_PERCENTAGE     14      /* int: current clock 
percentage */
 #define        CPU_MAXID               15      /* number of valid machdep ids 
*/
+/* Please do not add new CPU_xxx definitions; see comment above */
 
 /*
  * Structure for CPU_DISKINFO sysctl call.