Re: Rockchip RK3588

[Robert Swindells <rjs%fdy2.co.uk@localhost>]

I wrote:
>Johann Rudloff <johann%sinyax.net@localhost> wrote:
>>On 2 September 2025 21:22:45 CEST, Robert Swindells <rjs%fdy2.co.uk@localhost> wrote:
>>>I can now get mine to boot NetBSD once using EDK2, after clearing out
>>>the SPI flash and rewriting the sd card, it freezes with no console
>>>output on second and subsequent boots.
>>>
>>>Have given up for now and will work on fdt drivers instead.
>>
>> Just a few days ago I rebased my earlier patches towards FDT drivers
>> for the rk3588 on top of HEAD:
>>
>> https://git.sr.ht/~cypheon/NetBSD
>> (USB2.0, eMMC, SDHC, and HDMI are working. Currently no PCIe / onboard ethernet support, though)
>
> I think that the PCIe drivers should be fairly easy to port from
> OpenBSD, they have a similar structure to the USB-C one that I imported
> recently.

I have got the PCIe PHY and host controller drivers from OpenBSD to compile.

The host controller isn't doing anything when it the driver attach
function enables link training.

My next thing to check is whether all the power stuff for it is enabled
so have started looking at your tree.

>> I'm currently restarting an attempt to get those patches cleaned up and
>> submitted for merging.
>>
>> I only have a Rock5B for testing, but maybe you find something useful in
>> that tree for your board?
>
> I will take a look.

The way that you have done the RK806 driver by putting an SPI attachment
in an I2C source file looks messy to me, it doesn't share anything with
the i2c code.

I have split it out into its own file under dev/spi in my tree and made
some changes to match the recent spi updates.

Copied across your rkpmu driver, how complete do you think this is?