Port-arm archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Using MMC on HoneyComb LX2 (patch)



> On Mar 27, 2024, at 11:31 AM, David Young <dyoung%pobox.com@localhost> wrote:
> 
> On Wed, Mar 27, 2024 at 09:35:44AM -0300, Jared McNeill wrote:
>> NACK on this patch. It assumes that all LX2K have some card present on the
>> second SDHCI controller.
>> 
>> The device node for eMMC has a "non-removable" property. You should use that
>> (see acpi_dsd_bool) to determine if the card is always present.
>> 
>> I think if a driver sets SDHC_FLAG_ALWAYS_PRESENT, it shouldn't have to
>> provide a card detect callback -- this should all be handled in sdhc.c.
> 
> Ok, I will make these changes and try them.
> 
> Does anybody have a HoneyComb LX2 or other LX2K-based board without MMC
> installed?  I guess that on such a board the ACPI node for MMC may be
> absent.  If it is present, then initialization will fail.  Either way,
> the MMC will not attach.

I have one:

	https://dmesgd.nycbug.org/index.cgi?do=view&id=6646

…but it only sees the SD card that has the UEFI image.  I’ll have to dig it out and take a closer look later this week.

-- thorpej



Home | Main Index | Thread Index | Old Index