Port-arm archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Using MMC on HoneyComb LX2 (patch)



On Wed, Mar 27, 2024 at 09:35:44AM -0300, Jared McNeill wrote:
> NACK on this patch. It assumes that all LX2K have some card present on the
> second SDHCI controller.
> 
> The device node for eMMC has a "non-removable" property. You should use that
> (see acpi_dsd_bool) to determine if the card is always present.
> 
> I think if a driver sets SDHC_FLAG_ALWAYS_PRESENT, it shouldn't have to
> provide a card detect callback -- this should all be handled in sdhc.c.

Ok, I will make these changes and try them.

Does anybody have a HoneyComb LX2 or other LX2K-based board without MMC
installed?  I guess that on such a board the ACPI node for MMC may be
absent.  If it is present, then initialization will fail.  Either way,
the MMC will not attach.

David

-- 
David Young
dyoung%pobox.com@localhost    Urbana, IL    (217) 721-9981


Home | Main Index | Thread Index | Old Index