Re: Using MMC on HoneyComb LX2 (patch)

[Jason Thorpe <thorpej%me.com@localhost>]

> On Mar 26, 2024, at 6:34 PM, David Young <dyoung%pobox.com@localhost> wrote:
> 
> The SolidRun HoneyComb LX2 has a 64 GB MMC built in.  NetBSD did not
> attach the MMC until I patched sdhc@acpi.  See attachment.  Maybe
> somebody else can try it out.  Does it look ok to apply?

Couple of comments:

- The extra NULL checks in sdhc_acpi_attach() are superfluous; the function won’t be called if sdhc_acpi_find_slot() returns NULL in the first place (see sdhc_acpi_match()).

- Is the lack of card-detect really a property of the Freescale controller, or is it a property of the HoneyComb board?  If the latter, you need to look at some other property to make the determination.

-- thorpej