Re: RockPro64 pwmfan0 on NetBSD10.0_BETA couldn't get 'cooling-levels' property

[joelp%sdf.org@localhost]

>
> joelp%sdf.org@localhost wrote:
>> I'm running NetBSD10.0_BETA daily (June 7th) on a RockPro64. In my
>> dmesg:
>>
>> [     1.000004] pwmfan0 at simplebus0autoconfiguration error: : couldn't
>> get 'cooling-levels' property
>>
>> In src/sys/dev/fdt/pwm_fan.c
>>
>>    levels = fdtbus_get_prop(phandle, "cooling-levels", &len);
>>    if (len < 4) {
>>        aprint_error(": couldn't get 'cooling-levels' property\n");
>>        return;
>>    }
>>
>> This leaves the CPU cooling fan off, unfortunately. I did have the fan
>> running on NetBSD9.3.
>>
>> Any options to get at least the fan running at some constant speed?
>
> Try this:
>
> Index: rk3399-rockpro64.dts
> ===================================================================
> RCS file: /cvsroot/src/sys/arch/arm/dts/rk3399-rockpro64.dts,v
> retrieving revision 1.14
> diff -u -r1.14 rk3399-rockpro64.dts
> --- rk3399-rockpro64.dts        7 Nov 2021 17:11:43 -0000       1.14
> +++ rk3399-rockpro64.dts        9 Jun 2023 18:39:55 -0000
> @@ -113,6 +113,10 @@
>                 };
>         };
>
> +       fan: pwm-fan {
> +               cooling-levels = <0 100 150 200 255>;
> +       };
> +
>  #if 0
>         edp@ff970000 {
>                 status = "okay";
>

Thanks for the quick response. I added that patch to
src/sys/arch/arm/dts/rk3399-rockpro64.dts (my edit starts at line 116):
        };
    };

    fan: pwm-fan {
        cooling-levels = <0 100 150 200 255>;
    };

I refreshed source and did a clean build of tools and kernel:

===> Summary of results:
         build.sh command:    ./build.sh -U -u -j4 -O ../obj -m evbarm -a
aarch64 kernel=ROCKPRO64
         build.sh started:    Fri Jun  9 12:26:53 PDT 2023
         NetBSD version:      10.0_BETA
         MACHINE:             evbarm
         MACHINE_ARCH:        aarch64
         Build platform:      NetBSD 9.3 amd64
         HOST_SH:             /bin/sh
         MAKECONF file:       /etc/mk.conf
         TOOLDIR path:       
/home/joelp/src-netbsd10/src/../obj/tooldir.NetBSD-9.3-amd64
         DESTDIR path:       
/home/joelp/src-netbsd10/src/../obj/destdir.evbarm
         RELEASEDIR path:     /home/joelp/src-netbsd10/src/../obj/releasedir
         Updated makewrapper:
/home/joelp/src-netbsd10/src/../obj/tooldir.NetBSD-9.3-amd64/bin/nbmake-evbarm
         Building kernel without building new tools
         Building kernel:     ROCKPRO64
         Build directory:    
/home/joelp/src-netbsd10/src/../obj/sys/arch/evbarm/compile/ROCKPRO64
         Kernels built from ROCKPRO64:
          /home/joelp/src-netbsd10/src/../obj/sys/arch/evbarm/compile/ROCKPRO64/netbsd
         build.sh ended:      Fri Jun  9 12:34:08 PDT 2023
===>

Unfortunately, I'm still seeing the same message.

I'm happy to try anything else.

-Joel