New PCI resource manager vs RPi4 UEFI

[Tobias Nygren <tnn%NetBSD.org@localhost>]

Hi!

> Committed By:	jmcneill
> Date:		Fri Oct 14 22:10:16 UTC 2022
>
> Log Message:
> Add a PCI resource manager and use it on Arm ACPI platforms.

Unfortunately this broke ppb(4) and/or ahcisata(4) for me on RPi4.
Meant to bisect it sooner, but work came in between.
It fails to map the BAR in ahci_pci_match() so the device now shows as
"not configured".

> The current implementation assumes that the parent PCI-PCI bridge's
> are already configured. A worthwhile improvement in the future would be
> to support programming windows for bridges that are not fully configured.

I assume the firmware does set up the bridges since I am able to boot
from this drive, but I'd need to set up an SD card in order to dump
configuration space. Is there any way to enable use of the olden
configuration ways in a new kernel meanwhile?
Anything else worth trying?

Kind regards,
-Tobias

dmesg diff:

UEFI firmware (version UEFI Firmware v1.33 built at 17:06:11 on Mar  7 2022)
...
 acpipchb0 at acpi0 (PCI0, PNP0A08): PCI Express Host Bridge
 pci0 at acpipchb0 bus 0
 ppb0 at pci0 dev 0 function 0: vendor 14e4 product 2711 (rev. 0x10)
 ppb0: PCI Express capability version 2 <Root Port of PCI-E Root Complex> x1 @ 5.0GT/s
 pci1 at ppb0 bus 1
 ppb1 at pci1 dev 0 function 0: vendor 12d8 product 2404 (rev. 0x05)
 ppb1: PCI Express capability version 2 <Upstream Port of PCI-E Switch>
 ppb2 at pci2 dev 1 function 0: vendor 12d8 product 2404 (rev. 0x05)
 ppb2: PCI Express capability version 2 <Downstream Port of PCI-E Switch> x1 @ 5.0GT/s
 pci3 at ppb2 bus 3
-ahcisata0 at pci3 dev 0 function 0: vendor 1b4b product 9128 (rev. 0x20)
-ahcisata0: AHCI revision 1.20, 8 ports, 32 slots, CAP 0xc0309f07<PMD,ISS=0x3=Gen3,SNCQ,S64A>
-ahcisata0: interrupting at irq 176
+vendor 1b4b product 9128 (SATA mass storage, AHCI 1.0, revision 0x20) at pci3 dev 0 function 0 not configured
 ppb3 at pci2 dev 2 function 0: vendor 12d8 product 2404 (rev. 0x05)
 ppb3: PCI Express capability version 2 <Downstream Port of PCI-E Switch> x1 @ 5.0GT/s
 pci4 at ppb3 bus 4
-ahcisata1 at pci4 dev 0 function 0: vendor 1b4b product 9128 (rev. 0x20)
-ahcisata1: AHCI revision 1.20, 8 ports, 32 slots, CAP 0xc0309f07<PMD,ISS=0x3=Gen3,SNCQ,S64A>
-ahcisata1: interrupting at irq 177
+vendor 1b4b product 9128 (SATA mass storage, AHCI 1.0, revision 0x20) at pci4 dev 0 function 0 not configured
 ppb4 at pci2 dev 3 function 0: vendor 12d8 product 2404 (rev. 0x05)
 ppb4: PCI Express capability version 2 <Downstream Port of PCI-E Switch> x1 @ 5.0GT/s
 pci5 at ppb4 bus 5
...
-wd0 at atabus0 drive 0
-wd0: 1788 GB, 3720981 cyl, 16 head, 63 sec, 512 bytes/sect x 3750748848 sectors