Re: [PATCH 1/2] arm10_setup fix for OSK5912/OMAP5912

[Richard Earnshaw <Richard.Earnshaw%arm.com@localhost>]

On Wed, 2008-12-10 at 14:24 +0200, Mikko Rapeli wrote:

> diff --git a/sys/arch/arm/arm/cpufunc.c b/sys/arch/arm/arm/cpufunc.c
> index 987a067..79633fa 100644
> --- a/sys/arch/arm/arm/cpufunc.c
> +++ b/sys/arch/arm/arm/cpufunc.c
> @@ -2393,7 +2393,9 @@ arm10_setup(args)
>       __asm volatile ("mcr\tp15, 0, r0, c7, c7, 0" : : );
>  
>       /* Allow detection code to find the VFP if it's fitted.  */
> +#ifndef CPU_ARM9E
>       __asm volatile ("mcr\tp15, 0, %0, c1, c0, 2" : : "r" (0x0fffffff));
> +#endif /* not CPU_ARM9E */
>  
>       /* Set the control register */
>       curcpu()->ci_ctrl = cpuctrl;

Hmm, the ARM10 doesn't have this feature either, it's part of ARMv6.  I
think this might be a mis-merge in some of Matt's v6 support code (it
was previously part of the arm11 support code.  Look at the diff between
rev 1.83 and 1.84 when this was all merged in.

Matt?

R.
-- 
Richard Earnshaw             Email: Richard.Earnshaw%arm.com@localhost
ARM Ltd                      Phone: +44 1223 400569 (Direct + VoiceMail)
110 Fulbourn Road            Switchboard: +44 1223 400400
Cherry Hinton                Fax: +44 1223 400410
Cambridge CB1 9NJ            Web: http://www.arm.com/
UK

-- 
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium.  Thank you.