Port-arm archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] Disable fast softints on OMAP (was Re: Status of current on ARM? )



On Fri, Nov 14, 2008 at 09:42:41AM +0000, Chris Gilbert wrote:
> Mikko Rapeli wrote:
> > On Fri, Nov 14, 2008 at 09:06:00AM +0000, Chris Gilbert wrote:
> >> I'd say we'd be better finding out why FAST_SOFTINTS isn't fast :)  In
> >> theory it should be.  The fact it isn't suggests something is broken
> >> somewhere (perhaps not clearing a flag somewhere...)
> > 
> > In theory yes, but since this has been enabled and affecting OMAP since 
> > early
> > August, I'd rather see a workaround applied to OMAP now. Any fixes to
> > fast softints can easily be tested out when they become available.
> 
> hmm, I think there's a bug with cpu_dosoftints.  Looking at it, it's
> called from the end of the pic interrupt processing, where the
> intr_depth will be > 0

It seems to me that the FAST_SOFTINTS implementation was never complete,
or at least it didn't look like it when I was more actively hacking on
evbarm stuff this spring/summer.  Since I couldn't find a good description
of what needed to be done and any notes to help integrate them with a new
platform, I simply punted.

So I guess I'm agreeing with Mikko about reverting that, at least until
someone steps up to fix (and hopefully document) then.

(and yes, on my PXA, I don't have FAST_SOFTINTS enabled)

--rafal

-- 
  Time is an illusion; lunchtime, doubly so.     |/\/\|           Rafal Boni
                   -- Ford Prefect               |\/\/|      
rafal%pobox.com@localhost


Home | Main Index | Thread Index | Old Index