Re: Please review wip/grub2

[Grégoire Sutre <gregoire.sutre%gmail.com@localhost>]

On 07/27/2012 09:44 AM, OBATA Akio wrote:

> (pkglint should be fixed, USE_TOOLS+=msgfmt should be suggested
> instead).

Ok.

> Usually, whole gettext will not be required, just libintl and/or
> gettext tools.
>
> Why 0.17 or later is required?

In fact, it seems that it's not required for wip/grub2.  I've started
by upgrading wip/grub2-current, and then used it to upgrade wip/grub2.
For wip/grub2-current, I get the following error during build with
gettext-0.14.6 (the latest version pre 0.17 in pkgsrc, afaics):

gmake[3]: Entering directory
`/tmp/pkgsrc/wip/grub2-current/work.x86_64/grub-bazaar-snapshot/po'
/usr/pkg/bin/msgmerge --update  --lang=ast ast.po grub.pot
......................................................................
done.
rm -f ast.gmo && /usr/pkg/bin/msgfmt --endianness=little -c --statistics
--verbose -o ast.gmo ast.po
/usr/pkg/bin/msgfmt: unrecognized option `--endianness=little'

I'll fix wip/grub2 so that it requires only what is needed.


> INSTALL files is probably wrong, because it is impossible to build
> with native gcc-4.1.3 on NetBSD-5.1 :(

Thanks for the report.  I'll re-install NetBSD 5.1 to look into this.
I probably was the last GRUB developer building with gcc 4.1.3 before
I switched to NetBSD 6 and -current...


>> WARN: Makefile:63: "" is not valid for ABI. Use one of { 32 64 }
>> instead.
>>
>> I unset ABI on purpose, as otherwise the build fails on Debian
>> GNU/Linux amd64.  The reason is that ABI gets set to 64, which
>> makes the gcc wrapper append the flag -m64, causing problems (as
>> some files need to be compiled with -m32).  Likewise, if ABI is set
>> to 32, then the build fails.  In short, pkgsrc's gcc wrapper
>> shouldn't append a -mXX flag at all.  Is there a better way to do
>> this than by unsetting ABI?
>
> Is it means that some part must be build with native ABI, but rest of
> them be ABI=32 (i386)?

Yes.  I don't know precisely, but, AFAI, GRUB ``userland'' tools must
be build with native ABI and GRUB ``kernel + modules'' must be built
with ABI=32.

Grégoire

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review