Please review wip/grub2

[Grégoire Sutre <gregoire.sutre%gmail.com@localhost>]

Hi,

I've updated wip/grub2 to 2.00.  There are some pkglint warnings
that I don't know how to avoid.


WARN: Makefile:39: Please use BUILD_USES_MSGFMT=yes instead of this 
dependency.

This comes from the dependency:

DEPENDS+=               gettext>=0.17:../../devel/gettext

But I've not found any documentation on BUILD_USES_MSGFMT, nor
any package using it.  GRUB requires gettext 0.17 or later,
and it's also a runtime dependency.


WARN: Makefile:63: "" is not valid for ABI. Use one of { 32 64 } instead.

I unset ABI on purpose, as otherwise the build fails on Debian
GNU/Linux amd64.  The reason is that ABI gets set to 64, which
makes the gcc wrapper append the flag -m64, causing problems
(as some files need to be compiled with -m32).  Likewise, if
ABI is set to 32, then the build fails.  In short, pkgsrc's
gcc wrapper shouldn't append a -mXX flag at all.  Is there a
better way to do this than by unsetting ABI?

On NetBSD, ABI is not set as far as I can see.

Thanks for your help,

Grégoire

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review