pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: please review wip/prover9

On Sun, Jan 16, 2011 at 06:31:17PM +0100, Pouya D. Tafti wrote:
> On 11 January 2011 11:37, Thomas Klausner
> <> wrote:
> > pkglint complains that the patches don't have comments.

Please add comments to the patches.

> > Why did you change them as you did? I agree that the Makefiles
> > shouldn't hardcode /bin/cp etc. but why the subshells?
> >
> > Make sure to send the changes upstream.

And please do that as well :)

> The bin/ files are intended for users as far as I can see, but it is
> very likely that most users would not need/use most of them.  We could
> put all but the main binaries elsewhere (perhaps under
> share/prover9/apps?) and include a MESSAGE saying where they are.
> What do you think?

If they are intended for users, they can stay where they are. No need
to make it more difficult to use them.

Please change PKGNAME, I think that prover9 should be the name and
2009.11A the version number, but pkgsrc splits on "-", so the name is
"prover9-2009" and the version number is "11A".


Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
pkgsrc-wip-review mailing list

Home | Main Index | Thread Index | Old Index