pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: please review wip/prover9

On 11 January 2011 11:37, Thomas Klausner
<> wrote:
> pkglint complains that the patches don't have comments.
> Why did you change them as you did? I agree that the Makefiles
> shouldn't hardcode /bin/cp etc. but why the subshells?
> Make sure to send the changes upstream.
> Are all the bin/ files supposed to be run by users?


Sorry about my delay in responding...

The subshells were not needed and I have removed them.

The bin/ files are intended for users as far as I can see, but it is
very likely that most users would not need/use most of them.  We could
put all but the main binaries elsewhere (perhaps under
share/prover9/apps?) and include a MESSAGE saying where they are.
What do you think?


Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
pkgsrc-wip-review mailing list

Home | Main Index | Thread Index | Old Index