Re: please review wip/prover9

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Fri, Jan 07, 2011 at 06:02:20PM +0100, Pouya D. Tafti wrote:
> Please review wip/prover9.  From the DESCR file:
> 
> This package includes Prover9, an automated theorem prover
> for first-order and equational logic, and Mace4, which
> searches for finite models and counter examples.

pkglint complains that the patches don't have comments.
Why did you change them as you did? I agree that the Makefiles
shouldn't hardcode /bin/cp etc. but why the subshells?

Make sure to send the changes upstream.

Are all the bin/ files supposed to be run by users?

Thanks,
 Thomas

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl 
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review