Re: runit uploaded

[Adrian Portelli <adrianp%stindustries.net@localhost>]

Neil Booth wrote:
> I have uploaded runit, a daemontools-like service supervisor
> that can also replace your init scheme if you like.
> 
> http://smarden.org/runit/
> 
> It's my first package so I'd appreciate someone taking a look.
> 

Hi,

For a start I'd suggest looking at OWN_DIRS (See 12.1.1. of pkgsrc.txt)
to create the SERVICEDIR as this does not get created at install time.
I think your attempting to do this ATM in your do-install target but it
isn't working anyway because of a typo :)  It would also mean you can
get rid of the DEINSTALL script and the ${SED} statement in your
do-build target.

I'd also suggest looking at ${PAX} for the installation of the
${WRKSRC}/etc directory and files.  See chat/ircd-hybrid/Makefile as an
example.  This would just mean you can simplify your do-install target
and remove the two "while read" loops.

Finally, you use a PLIST_SUBST+=SERVICEDIR=${SERVICEDIR} directive but I
can't see SERVICEDIR in use in the PLIST.  As a matter of point the
PLIST should not be use to manage anything outside of ${PREFIX} anyway.

HTH,

adrian.


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review