Re: runit uploaded

[Neil Booth <neil%daikokuya.co.uk@localhost>]

Adrian Portelli wrote:-

> For a start I'd suggest looking at OWN_DIRS (See 12.1.1. of pkgsrc.txt)
> to create the SERVICEDIR as this does not get created at install time.
> I think your attempting to do this ATM in your do-install target but it
> isn't working anyway because of a typo :)  It would also mean you can
> get rid of the DEINSTALL script and the ${SED} statement in your
> do-build target.
> 
> I'd also suggest looking at ${PAX} for the installation of the
> ${WRKSRC}/etc directory and files.  See chat/ircd-hybrid/Makefile as an
> example.  This would just mean you can simplify your do-install target
> and remove the two "while read" loops.
> 
> Finally, you use a PLIST_SUBST+=SERVICEDIR=${SERVICEDIR} directive but I
> can't see SERVICEDIR in use in the PLIST.  As a matter of point the
> PLIST should not be use to manage anything outside of ${PREFIX} anyway.

Adrian,

Thanks for the advice, and apologies for the belated reply.  Your
suggestions are a great improvement; I have implemented them and
updated the package in wip/.

Neil.


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review