Re: Please review wip/p5-PDL

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Wed, Jun 01, 2005 at 05:11:41AM +0000, Alan Post wrote:
>   1.  The imported package generates a few pkglint warnings:
> 
> WARN: possible direct use of command "test" found. Use ${TEST} instead.
> WARN: possible direct use of command "install" found. Use ${INSTALL} instead.

I think these are fixed with a newer pkglint.

> WARN: "BUILD_DEPENDS" has to appear earlier.
> WARN: "DEPENDS" has to appear earlier.

I fixed the second of those, the first is unfixable (because the
BUILD_DEPENDS is in an included bl3.mk file).

>   2.  The PDL 3D graphing library uses libGL and libGLU.  Should the
>       package pick them up from /usr/X11R6 or from graphics/MesaLib
>       and graphics/glu?

It should use the bl3.mk files for those provided in graphics/MesaLib
and graphics/glu. We can't assume that the files exist in /usr/X11R6
on all supported platforms.

Cheers,
 Thomas


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review