pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: ready for review: qcad (essentially done, I think)



On Tue, Mar 29, 2005 at 10:43:28AM -0500, J Chapman Flack wrote:
> Good to know, but for now I've left it at four - I don't know what
> Ribbonsoft intends with the -1, I've never seen any digit but 1 in that
> position on any of their downloads.  Would you recommend going to five?

Hm, we can always add another digit later, if we need it.

> When you build from the ribbonsoft download, you run a shell script that
> does that, instead of running make directly.  I suppose I could have done
> a package makefile that did nothing but run the original shell script, but
> it seemed more likely to integrate with the pkgsrc way of doing things to
> reverse-engineer the script and get the Makefile to do it right.

That's fine.

> > The Makefile.common is so short, I'd suggested just including
> > it in the appropriate Makefiles.
> 
> Hmm, I still sort of like factoring it out, just to reduce the chance that
> somebody changes something in one place and misses others.  Is that ok?

Yes, of course. I just like to reduce pkglint warnings ;) and we usually
only share the Makefile if it contains one of same tarball/patches/files.

Cheers,
 Thomas


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review



Home | Main Index | Thread Index | Old Index