Re: ready for review: qcad (essentially done, I think)

To: J Chapman Flack <flack%cs.purdue.edu@localhost>
Subject: Re: ready for review: qcad (essentially done, I think)
From: Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>
Date: Tue, 29 Mar 2005 17:20:22 +0200 See http://spamassassin.org/tag/ for more details. Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001 0.0 SF_CHICKENPOX_PERIOD BODY: Text interparsed with . 0.0 SF_CHICKENPOX_SLASH BODY: Text interparsed with / 0.0 SF_CHICKENPOX_MINUS BODY: Text interparsed with - 0.0 SF_CHICKENPOX_UNDERSCORE BODY: Text interparsed with _ 0.0 SF_CHICKENPOX_EQUAL BODY: Text interparsed with = 0.0 SF_CHICKENPOX_AT BODY: Text interparsed with @ 0.0 SF_CHICKENPOX_APOSTROPHE BODY: Text interparsed with ' -0.2 AWL AWL: From: address is in the auto white-list

On Thu, Mar 10, 2005 at 11:55:26PM -0500, J Chapman Flack wrote:
> I have an update of cad/qcad and since it is both a significant upgrade and
> my first pkg, I committed it in wip in case there are any suggestions how
> I could do things better.

pkglint is slightly unhappy:
WARN: Makefile:41: Trailing white space.
WARN: Makefile:15: USE_X11 should be set to YES or yes
WARN: Makefile:16: GNU_CONFIGURE should be set to YES or yes

>From Makefile:
DISTNAME=               qcad-2.0.4.0-1.src
# what to do about this numbering? RibbonSoft really seems to use four digits
# (there's a 2.0.4.7 for some platforms), though I don't know about the
# thing after the hyphen, which always seems to be 1. Can I use four digits?
PKGNAME=                qcad-2.0.4.0

You can use five digits too, just make it 2.0.4.0.1.

# XXX how to determine the below dynamically?
MAKE_ENV+=              QMAKESPEC=${QTDIR}/mkspecs/default
PREPEND_PATH+=          ${QTDIR}/bin

What do you mean?

Wow, the next comment is huge, but seems ok.

The one after that:
# Just setting BUILD_DIRS would be adequate if qcad could be built with
# "prepare all" in each module, one by one.  But qcad needs all modules to
# be prepare'd before any can be all'd, so prepare them here in a separate
# loop duplicated from do-build.  The unmodified do-build then takes care
# of the "all".  I didn't see an easier way.

How does is this supposed to work when you build from source manually?
Do you have to go into each dir and do 'make prepare' manually?

The Makefile.common is so short, I'd suggested just including
it in the appropriate Makefiles.

The TODO contains no real items.

Haven't built it yet, because I don't have qt3-tools installed
on my desktop machine here.
 Thomas

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review

Follow-Ups:
- Re: ready for review: qcad (essentially done, I think)
  - From: Thomas Klausner
- Re: ready for review: qcad (essentially done, I think)
  - From: Peter I. Hansen

References:
- ready for review: qcad (essentially done, I think)
  - From: J Chapman Flack

Prev by Date: Re: Please review package wip/openttd
Next by Date: Re: ready for review: qcad (essentially done, I think)
Previous by Thread: Re: ready for review: qcad (essentially done, I think)
Next by Thread: Re: ready for review: qcad (essentially done, I think)
Indexes:

Home | Main Index | Thread Index | Old Index