Re: CVS commit: wip/adamem

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Tue, Jan 11, 2005 at 11:48:11AM -0800, Greg Troutman wrote:
> Import into wip/adamem
> 
> Log Message:
> Emulator for Colecovision game console and Adam computer system.

Some comments:
Can the two SUBST_CLASSES be replaced with CPPFLAGS+= -DFOO?

bsd.pkg.mk should be included last.

patch-ab is probably not necessary with current ossaudio.buildlink3.mk

Should not use -lossaudio directly (in patch-ac) but ${LIBOSSAUDIO}
instead.

How about installing a short shell script that does step 3) of
the message for the user?

Cheers,
 Thomas


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review