Re: please review lighttpd and php-fcgi

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Mon, Feb 14, 2005 at 01:01:23PM +0100, Piotr Stolc wrote:
> 1. lighttpd - fast as lightning http server, homepage: http://lighttpd.net
> 
> It is very fast and has low memory consumptions, has many loadable modules
> like fastcgi, rewrite and compress.
> I don't know now what to do with mod_mysql_vhost which compiles even when I
> tell configure not to do this.
> 
> The PKGNAME and DISTNAME variables are specified separately because lighttpd
> snapshots' name convention is like "lighttpd-1.3.11-${DATE}.tar.gz" and this
> separation allows handling it easy.

pkglint is happy.

The post-patch target could be replaced by SUBST_*, see mk/subst.mk.

The mysql behaviour is a bug: does setting MYSQLCONFIG to /bin/false
in CONFIGURE_ENV help?

Two files are missing from the PLIST:
man/man1/lighttpd.1
man/man1/spawn-fcgi.1

Otherwise this package looks very good.

> 2. php-fcgi - it's just PHP FastCGI binary, using .mk from lang/php - based
> on www/ap-php :). I've tested it with php4 on NetBSD 2.0 and it works ok.

Why is LIBTOOL_OVERRIDE undefined?
ap-php for example sets SHLIBTOOL_OVERRIDE instead.

Otherwise, this looks ok too.

Good work for first packages!

Cheers,
 Thomas


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review