Re: Please review wip/rlab

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Fri, Feb 11, 2005 at 02:27:44PM +0100, Peter Bex wrote:
> I just added rlab, a matlab-like research tool/mathematic high-level
> programming language which we have to use for a course at university.
> 
> Please review.

The options handling could and probably should be put into options.mk.

DEPENDS should not look like this:
DEPENDS+=               gnuplot-*:../../graphics/gnuplot
but like this:
DEPENDS+=               gnuplot-[0-9]*:../../graphics/gnuplot

The reason is that there could at some point be a gnuplot-foo
package that has nothing to do with gnuplot and would still fulfill
the first dependency, but not the second.

CONFIGURE_ARGS+=        --with-plplot=${PREFIX}/lib
this should use ${BUILDLINK_PREFIX.plplot} instead.

Why does the package need GNU readline? Please at least
add a comment, or file a bug report against NetBSD's readline emulation.

This looks weird, in patch-ac:
-test -z "$INSTALL_SCRIPT" && INSTALL_SCRIPT='${INSTALL_PROGRAM}'
+test -z "$INSTALL_SCRIPT" && INSTALL_SCRIPT='${INSTALL_SCRIPT}'
If INSTALL_SCRIPT is not defined, you define it to itself? :)

Why does the package install
lib/${PKGNAME}/Makefile
lib/${PKGNAME}/Makefile.in
at all?

And, shouldn't all/most of the files in lib/ be in share/${PKGNAME} instead?

This package uses f77, so it should set USE_LANGUAGES to fortran
(and c/c++, depending on which applies).

make deinstall complains:
pkg_delete: unable to completely remove directory '/usr/pkg/lib/rlab-2.1.05'
pkg_delete: couldn't entirely delete package `rlab-2.1.05'
(perhaps the packing list is incorrectly specified?)
because
@dirrm lib/${PKGNAME}/rlib
and lots of files in lib/${PKGNAME} are missing from the PLIST.

First rule of pkgsrc:
'make install && make deinstall && make print-PLIST' should work
fine :)
make print-PLIST doesn't find the files in lib/${PKGNAME} because
their timestamp is not updated, but the deinstall step already
fails.

Cheers,
 Thomas


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review