Re: Please review wip/libhttpd

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Sun, Feb 06, 2005 at 01:41:57AM +0100, Ola Eriksson wrote:
> Package wip/libhttpd has been imported into pkgsrc-wip. Please review this 
> package!

pkglint is happy.

DESCR should only contain a program description.
The license part should go into the Makefile, e.g. as
LICENSE=fee-based-commercial-use
I'm not quite sure if that's correct though, please double-check.

MAINTAINER should be your email address, definitely not packages@
USE_PKGLOCALEDIR is not needed. (I know that url2pkg adds that
a bit too often -- it's only needed if locale files are installed
by the package; a good quick test is to look for PKGLOCALEDIR
in the print-PLIST output).

CATEGORIES should be www, not wip.

You should install some documentation, even if the package does
not do this automatically. Use a post-install target for that.
The contents of doc/ look good for this; install them with
INSTALL_DATA to ${PREFIX}/share/doc/libhttpd after creating
that dir with INSTALL_DATA_DIR, and add them to the PLIST.

Otherwise it looks fine.

Cheers,
 Thomas


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review