pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Low-hanging fruit - editline



If anyone is interested in easy fixes that need doing and would be a good entry into development work, the broken editline update has exposed a bunch of packages that incorrectly pull it in directly rather than using mk/readline.buildlink3.mk.

Head to:

  https://reports.pkgci.org/SmartOS/upstream/trunk/20250517.2249/meta/report.html

and find all the packages that are "indirect-failed" due to the editline failure, and test their build on an OS that provides readline as the default implementation (basically anything that isn't BSD-based), or with READLINE_DEFAULT=readline set.

For the most part it should simply be a case of replacing:

  .include "../../devel/editline/buildlink3.mk"

with:

  .include "../../mk/readline.buildlink3.mk"

and verifying that it builds correctly. Some packages may need a small amount of extra work to pass the right flags or variables, but there are plenty of examples in the tree to help here.

Cheers,

--
Jonathan Perkin                    pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com


Home | Main Index | Thread Index | Old Index