Re: Fallout from inpcb changes in NetBSD 9.99.104/105 [was: Re: pkgsrc-2022Q4 branch released]

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

On Fri, 2022-12-30 at 10:30 +0100, Matthias Petermann wrote:
> Hi,
> 
> On 30.12.22 03:31, David H. Gutteridge wrote:
> > On Thu, 29 Dec 2022 at 12:33:43 +0100, BERTRAND Joël wrote:
> > > First issue on Netbsd-10. net-snmp build fails with following
> > > error:
> > > 
> > > mibgroup/mibII/ipv6.c: In function 'var_udp6':
> > > mibgroup/mibII/ipv6.c:1630:19: error: 'struct in6pcb' has no
> > > member
> > > named 'in6p_af'
> > > 1630 |         if (in6pcb.in6p_af != AF_INET6)
> > >       |                   ^
> > > mibgroup/mibII/ipv6.c:1655:34: error: 'struct in6pcb' has no
> > > member
> > > named 'in6p_laddr'
> > > 1655 |             newname[j++] = in6pcb.in6p_laddr.s6_addr[i];
> > >       |                                  ^
> > > In file included from /usr/include/sys/stdint.h:35,
> > >                  from /usr/include/sys/inttypes.h:39,
> > >                  from /usr/include/sys/param.h:104,
> > >                  from ../include/net-snmp/system/netbsd.h:3,
> > >                  from ../include/net-snmp/net-snmp-config.h:2324,
> > >                  from mibgroup/mibII/ipv6.c:6:
> > 
> > This is fallout from inpcb changes made as of 9.99.104. A similar
> > issue
> > exists with sysutils/lsof. (I occasionally use the latter, but
> > hadn't
> > got around to looking at this in detail.)
> 
> good to know - I see the same problem (pkgsrc-2022q4, NetBSD 10.0_BETA
> build 2022-12-23). Here php-snmp and glusterfs depend on it. The inpcb
> topic is foreign to me, does it make sense for a beginner to deal with
> it? Will it come down to a trivial patch for net-snmp (renaming a
> member of the structure) or major overhaul?

mrg@ and I worked on getting it to compile on >= 9.99.104. These
patches have landed in pkgsrc -current. Neither of us actually use this
package nor any that depend on it, so if anyone is able to test
functionality, it would be appreciated. (Also, sysutils/lsof was fixed
too, by mrg@.)

(The changes deal with different naming and placement of structure
members, so not a major overhaul, but patches to a few files.)

Regards,

Dave