Mark Davies <mark%ecs.vuw.ac.nz@localhost> writes: > On 22/03/17 20:59, Thomas Klausner wrote: >> Add >> BUILDLINK_API_DEPENDS.libLLVM+= libLLVM>=4.0 >> to options.mk before the llvm inclusion, bump PKGREVISION and commit. > > done. Though I'm not sure why we need to force the libLLVM>=4.0. My > reading of the patches is that they will also work with an older llvm, > though I haven't actually tried. Great -- thanks for getting the patch in. As for whether the forcing to >=4 is needed -- I don't know, but we only expect consistent pkgsrc trees to work and llvm 4 happened before the patch, so your patch seeing < 4 is a broken situation anyway, and I am therefore unconcerned that if fails. But I also don't see that it hurts, so let's let things be that aren't problems. I did a test build on netbsd-7 amd64. which built fine, and I see Patrick Welche reports that it builds on Ubuntu (16.04.2 LTS presumably). My mac build still fails with the llvm option. So the remaining questions are if SunOS still fails, and also all other platforms.
Attachment:
signature.asc
Description: PGP signature