Re: lang/php70/patches/patch-ext_standard_php__dns.h

[Matthias Ferdinand <mf+ml.pkgsrc-users%netzwerkagentursaarland.de@localhost>]

On Thu, Sep 29, 2016 at 04:20:38PM +0200, Matthias Ferdinand wrote:
> On Wed, Sep 28, 2016 at 02:10:14PM -0500, Jeremy C. Reed wrote:
> > On a Ubuntu Linux system:
> > 
> > /home/reed/src/netbsd/pkgsrc/lang/php70/work/php-7.0.11/ext/standard/dns.c:420:2: 
> > error: incompatible type for argument 1 of '_php_dns_free_res'
> >   php_dns_free_handle(handle);
> >   ^
> > /home/reed/src/netbsd/pkgsrc/lang/php70/work/php-7.0.11/ext/standard/dns.c:338:13: 
> > note: expected 'struct __res_state *' but argument is of type 'struct 
> > __res_state'
> >  static void _php_dns_free_res(struct __res_state *res) { /* {{{ */
> >             ^
> > 
> > So I reverted patch  patches/patch-ext_standard_php__dns.h
> > 
> > I couldn't find the complete history of this patch (cvs log says private 
> > mail) nor find similar change upstream.
> 
> Hi,
> 
> I sent a patch for that in April:
> http://mail-index.netbsd.org/pkgsrc-users/2016/04/26/msg023312.html

ah sorry, not for this exactly, but for the original
php_dns_free_handle() problem. Looks like php7 and up now have their own
handling of __GLIBC__ systems.
So reverting the patch patch-ext_standard_php__dns.h seems like the
right thing to do.


Matthias