pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/geography/gama



Thomas Klausner <wiz%NetBSD.org@localhost> writes:

>> > If we know that upstream really wants c++14, I think we should add it
>> > in USE_LANGUAGES. What's the disadvantage?
>> 
>> The disadvantage is that you are now tied in to updating USE_LANGUAGES every
>> time a package changes the standard it targets.
>
> Ok, accepted.

But with not having it in USE_LANGUAGES because it must be changed, we
are having to change GCC_REQD instead.  And we have to set such
variables for every other compiler.   This is vastly more work, and it's
not good software engineering to open code things.

> Hm, not sure about this one though - we had some fallout because
> poppler-qt5's header files now need a newer C++ than some of its
> users. In this case, setting the dependency's USE_LANGUAGES to c++17
> is the easiest solution.

I see the point that a package that depends on poppler-qt5 and does not
document in README and require when configuring the specific language
that the poppler-qt5 *headers* are in is a bug.

But that's orthogonal to declaring the language version needed rather
than opencoding a rule based on it.



Home | Main Index | Thread Index | Old Index