pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/geography/gama



On Mon, Jul 10, 2023 at 03:01:23PM +0000, nia wrote:
> On Mon, Jul 10, 2023 at 09:22:37AM -0400, Greg Troxel wrote:
> > "Nia Alarie" <nia%netbsd.org@localhost> writes:
> > 
> > > Modified Files:
> > >   pkgsrc/geography/gama: Makefile
> > >
> > > Log Message:
> > > gama: Sync compiler requirements with reality.
> > 
> > > @@ -11,10 +11,13 @@ HOMEPAGE=     https://www.gnu.org/s/gama/
> > >  COMMENT= Geodetic network adjustment (surveying)
> > >  LICENSE= gnu-gpl-v2 # or later
> > >  
> > > -USE_LANGUAGES=   c c++11
> > > +USE_LANGUAGES=   c c++
> > 
> > Why is c++11 changed to c++, rather than to c++14?
> 
> USE_LANGUAGES is for forcing a -std=cXX value through the wrappers,
> gama already uses -std=c++14 upstream.

If we know that upstream really wants c++14, I think we should add it
in USE_LANGUAGES. What's the disadvantage?

That also makes it clearer why GCC_REQD is set (though I think we
should comment those too, usually).
 Thomas



Home | Main Index | Thread Index | Old Index