Re: CVS commit: pkgsrc/geography/gama

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Tue, Jul 11, 2023 at 01:22:46PM +0100, Jonathan Perkin wrote:
> * On 2023-07-11 at 13:16 BST, Thomas Klausner wrote:
> 
> > On Mon, Jul 10, 2023 at 03:01:23PM +0000, nia wrote:
> > > On Mon, Jul 10, 2023 at 09:22:37AM -0400, Greg Troxel wrote:
> > > > "Nia Alarie" <nia%netbsd.org@localhost> writes:
> > > >
> > > > > Modified Files:
> > > > >       pkgsrc/geography/gama: Makefile
> > > > >
> > > > > Log Message:
> > > > > gama: Sync compiler requirements with reality.
> > > >
> > > > > @@ -11,10 +11,13 @@ HOMEPAGE= https://www.gnu.org/s/gama/
> > > > >  COMMENT=     Geodetic network adjustment (surveying)
> > > > >  LICENSE=     gnu-gpl-v2 # or later
> > > > >
> > > > > -USE_LANGUAGES=       c c++11
> > > > > +USE_LANGUAGES=       c c++
> > > >
> > > > Why is c++11 changed to c++, rather than to c++14?
> > > 
> > > USE_LANGUAGES is for forcing a -std=cXX value through the wrappers,
> > > gama already uses -std=c++14 upstream.
> > 
> > If we know that upstream really wants c++14, I think we should add it
> > in USE_LANGUAGES. What's the disadvantage?
> 
> The disadvantage is that you are now tied in to updating USE_LANGUAGES every
> time a package changes the standard it targets.

Ok, accepted.

> I agree with nia that it should be "c++" unless we absolutely need to
> override it (which is effectively an upstream bug).

Hm, not sure about this one though - we had some fallout because
poppler-qt5's header files now need a newer C++ than some of its
users. In this case, setting the dependency's USE_LANGUAGES to c++17
is the easiest solution.

What do you think about cases like these?
 Thomas