Re: CVS commit: [pkg_install-renovation] pkgsrc/pkgtools/pkg_install/files/lib

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Mon, Dec 29, 2008 at 12:19:27AM +0100, Thomas Klausner wrote:
> On Sun, Dec 28, 2008 at 06:03:31PM +0000, Alistair Crooks wrote:
> > > revision 1.55
> > > date: 2005/11/03 21:59:55;  author: dillo;  state: Exp;  lines: +8 -273
> > > Split dewey compare functions into their own file dewey.c so they
> > > can be used in a forthcoming Perl module.
> > > 
> > > Joint work with Thomas Klausner.
> > 
> > http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/pkg_install/lib/Attic/dewey.c?annotate=1.1&only_with_tag=MAIN
> > 
> > Lines 49 and 50 show that the fields are now ints.
> 
> IIRC, we didn't see a need for int64_t and it was easier to make
> portable this way (int64_t doesn't exist everywhere).  We didn't
> explicitly note this (which would probably have been better).
> I don't remember seeing any bug reports caused by this.

I don't know about int64_t not being available everywhere, but I'm
fairly sure that a 64-bit integer entity does exist everywhere that
pkg_install is compiled.  I don't remember seeing any bug reports about
this either, and as I mentioned before, I wouldn't expect to see any,
for various reasons; I was just wondering why it was changed without
explanation.
 
> > (And my apologies if this came across as joerg-bashing, it certainly
> > wasn't intended).
> 
> So was it intended as dillo-and-wiz-bashing? :)

Absolutely not, no bashing intended.

Regards,
Alistair