Re: CVS commit: [pkg_install-renovation] pkgsrc/pkgtools/pkg_install/files/lib

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Sun, Dec 28, 2008 at 04:43:42PM +0100, Joerg Sonnenberger wrote:
> On Sun, Dec 28, 2008 at 06:31:17AM +0000, Alistair Crooks wrote:
> > It would hav been better if the original 64bit integer version numbers
> > had been carried over from the original code when it was split out
> > into its own file, rather than silently moving them to 32 bits (in
> > response to the commit log on HEAD, NetBSD doesn't run on ILP64, and I
> > can think of no pkgsrc-supported platform that is ILP64, at least
> > until Unicos gets supported).
> 
> I might be blind, but I can't find any 64bit arithmetic even in the
> NetBSD 1.4 version of the code. deweycmp is clearly using plain ints on
> those.

Yeah, it's a tad hard to find now, but:

http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/pkg_install/lib/Attic/str.c?annotate=1.32&only_with_tag=MAIN

Lines 108 and 109 define the array of 64 bit integers used for the
individual components of the version number array.  Version 1.54 had
the same int64_t values. 1.55 was the split into dewey.[ch].

> revision 1.55
> date: 2005/11/03 21:59:55;  author: dillo;  state: Exp;  lines: +8 -273
> Split dewey compare functions into their own file dewey.c so they
> can be used in a forthcoming Perl module.
> 
> Joint work with Thomas Klausner.

http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/pkg_install/lib/Attic/dewey.c?annotate=1.1&only_with_tag=MAIN

Lines 49 and 50 show that the fields are now ints.

(And my apologies if this came across as joerg-bashing, it certainly
wasn't intended).

Regards,
Alistair