pkg/59790: multimedia/ffmpeg6 with x264 enabled doesn't build

[kre%munnari.OZ.AU@localhost]

>Number:         59790
>Category:       pkg
>Synopsis:       multimedia/ffmpeg6 with x264 enabled doesn't build
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 25 18:55:00 +0000 2025
>Originator:     Robert Elz
>Release:        NetBSD 11.99.3   (irrelevant)
>Organization:
>Environment:
	
	
System: NetBSD jacaranda.noi.kre.to 11.99.3 NetBSD 11.99.3 (JACARANDA:1.1-20251109) #226: Sun Nov 9 16:44:17 +07 2025 kre%jacaranda.noi.kre.to@localhost:/usr/obj/testing/kernels/amd64/JACARANDA amd64
Architecture: x86_64		(all irrelevant)
Machine: amd64
>Description:

multimedia/ffmpeg6/options.mk (rev:1.2 2023/11/19) includes:

PKG_SUPPORTED_OPTIONS=  ass aom bluray doc fdk-aac fontconfig freetype jack \
	lame libvpx libwebp opencore-amr opus pulseaudio rav1e rpi rtmp \
	speex tesseract theora vorbis x11 x264 x265 xvid
PKG_SUGGESTED_OPTIONS=  ass aom bluray freetype fontconfig gnutls lame \
	libvpx libwebp opus speex theora vorbis x264 x265 xvid

That is, the x264 option is enabled by default.

Later:

# x264 support
.if !empty(PKG_OPTIONS:Mx264)
BUILDLINK_API_DEPENDS.x264+=    x264>=20220601
CONFIGURE_ARGS+=        --enable-libx264
.include "../../multimedia/x264-devel/buildlink3.mk"
.else
CONFIGURE_ARGS+=        --disable-libx264
.endif


The issue is that there is (no longer) a ../../multimedia/x264-devel
directory to find things in.

The ffmpeg7 package is similar, but instead has:

# x264 support
.if !empty(PKG_OPTIONS:Mx264)
BUILDLINK_API_DEPENDS.x264+=    x264>=20220601
CONFIGURE_ARGS+=        --enable-libx264
.include "../../multimedia/x264/buildlink3.mk"
.else
CONFIGURE_ARGS+=        --disable-libx264
.endif

In the past (I presume at a time when x264-devel existed) this used
to work fine.

>How-To-Repeat:
	Try building it, or simpler

		make VARNAME=PKGNAME show-var

	in the ffmpeg6 directory.   Expect to see:

jacaranda$ make VARNAME=PGKNAME show-var
make: /tmp/mktemp.D3ePVgY8/multimedia/ffmpeg6/options.mk:228: Could not find ../../multimedia/x264-devel/buildlink3.mk
        in /tmp/mktemp.D3ePVgY8/multimedia/ffmpeg6/Makefile:30
make: Fatal errors encountered -- cannot continue
make: stopped making "show-var" in /tmp/mktemp.D3ePVgY8/multimedia/ffmpeg6

>Fix:
	Probably just 228s/x264-devel/x264/ from the .include line in
	ffmpeg6/options.mk, but I don't know enough about what x264-devel
	used to be, as compared to the current x264 to be able to meaningfully
	conclude it is that simple.