pkg/59775: pkgsrc/www/firefox patch-js_src_jit_arm64_vixl_Registers-vixl.h

[jun%soum.co.jp@localhost]

>Number:         59775
>Category:       pkg
>Synopsis:       pkgsrc/www/firefox  patch-js_src_jit_arm64_vixl_Registers-vixl.h
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 19 07:50:01 +0000 2025
>Originator:     Jun Ebihara
>Release:        NetBSD 11.99.3 and pkgsrc 2025 Nov.19
>Organization:
SOUM Corporation
>Environment:
NetBSD arm64 11.99.3 NetBSD 11.99.3 (GENERIC64) #0: Mon Oct  6 07:51:44 UTC 2025  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/evbarm/compile/GENERIC64 evbarm

>Description:
pkgsrc/www/firefox build failed on NetBSD/aarch64. 

/mnt/aarch64/pkgsrc/www/firefox/work.aarch64/firefox-145.0/js/src/jit/arm64/vixl/Registers-vixl.h: In member function 'constexpr bool vixl::CPURegister::IsMerging() const':
/mnt/aarch64/pkgsrc/www/firefox/work.aarch64/firefox-145.0/js/src/jit/arm64/vixl/Registers-vixl.h:378:56: error: call to non-'constexpr' function 'bool vixl
::CPURegister::IsPRegister() const'
  378 |   constexpr bool IsMerging() const { return IsPRegister() && (qualifiers_ == kMerging); }
      |                                             ~~~~~~~~~~~^~^
/mnt/aarch64/pkgsrc/www/firefox/work.aarch64/firefox-145.0/js/src/jit/arm64/vixl/Registers-vixl.h:191:8: note: 'bool vixl::CPURegister::IsPRegister() const'
 declared here
  191 |   bool IsPRegister() const { return GetType() == kPRegister; }
      |        ^~~~~~~~~~~

>How-To-Repeat:
1. Boot NetBSD/aarch64 on RPI4:
https://cdn.netbsd.org/pub/NetBSD/misc/jun/raspberry-pi/2025-10-07-aarch64/2025-10-07-netbsd-raspi-aarch64.img.gz
2. make pkgsrc/www/firefox


>Fix:
https://github.com/ebijun/NetBSD/blob/master/pkgsrc/firefox/patch-js_src_jit_arm64_vixl_Registers-vixl.h

$NetBSD$

Add constexpr keyword to the member function.

--- js/src/jit/arm64/vixl/Registers-vixl.h.orig	2025-11-19 07:12:36.568771038 +0000
+++ js/src/jit/arm64/vixl/Registers-vixl.h
@@ -188,13 +188,13 @@ class CPURegister {
   bool IsRegister() const { return GetType() == kRegister; }
   bool IsVRegister() const { return GetType() == kVRegister; }
   bool IsZRegister() const { return GetType() == kZRegister; }
-  bool IsPRegister() const { return GetType() == kPRegister; }
+  constexpr bool IsPRegister() const { return GetType() == kPRegister; }
 
   bool IsNone() const { return GetType() == kNoRegister; }
 
   // `GetType() == kNoRegister` implies IsNone(), and vice-versa.
   // `GetType() == k<Foo>Register` implies Is<Foo>Register(), and vice-versa.
-  RegisterType GetType() const {
+  constexpr RegisterType GetType() const {
     switch (bank_) {
       case kNoRegisterBank:
         return kNoRegister;