Re: PR/59478 CVS commit: pkgsrc/comms/asterisk22

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

> On Aug 31, 2025, at 11:35 PM, John Nemeth via gnats <gnats-admin%NetBSD.org@localhost> wrote:
> 
> The following reply was made to PR pkg/59478; it has been noted by GNATS.
> 
> From: jnemeth%CornerstoneService.ca@localhost (John Nemeth)
> To: gnats-bugs%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost, rwhitlock22%gmail.com@localhost
> Cc: 
> Subject: Re: PR/59478 CVS commit: pkgsrc/comms/asterisk22
> Date: Sun, 31 Aug 2025 20:12:22 -0700
> 
> On Aug 31, 20:50, "Rob Whitlock via gnats" wrote:
> }  > On Aug 11, 2025, at 2:30 AM, John Nemeth <jnemeth%netbsd.org@localhost> wrote:
> }  > 
> }  > The following reply was made to PR pkg/59478; it has been noted by GNATS.
> }  > 
> }  > From: "John Nemeth" <jnemeth%netbsd.org@localhost>
> }  > To: gnats-bugs%gnats.NetBSD.org@localhost
> }  > Cc: 
> }  > Subject: PR/59478 CVS commit: pkgsrc/comms/asterisk22
> }  > Date: Mon, 11 Aug 2025 06:28:14 +0000
> }  > 
> }  > Module Name:	pkgsrc
> }  > Committed By:	jnemeth
> }  > Date:		Mon Aug 11 06:28:14 UTC 2025
> }  > 
> }  > Modified Files:
> }  > 	pkgsrc/comms/asterisk22: Makefile PLIST distinfo
> }  > 	pkgsrc/comms/asterisk22/patches: patch-configure patch-configure.ac
> }  > 	    patch-include_asterisk_autoconfig.h.in patch-res_res__xmpp.c
> }  > Removed Files:
> }  > 	pkgsrc/comms/asterisk22/patches: patch-main_config.c
> }  > 
> }  > Log Message:
> }  > Update Asterisk 22.5.1.  This catches up with multiple versions.
> }  > 
> }  > pkgsrc changes:
> }  > - minor pkglint fixup
> }  > - fix PR pkg/58978
> }  > - fix PR pkg/59478
> }  > 
> }  > -----
> }  
> }  This fixes the issues for asterisk22 but the issues for asterisk16,18,19,21
> }  remain. Here are some patches that add CONFIG_SHELL where
> }  needed and add the :run suffix to bash in USE_TOOLS where it is
> }  missing, because there are installed scripts that require bash in
> }  /usr/pkg/libdata/asterisk/scripts.
> 
>      I believe that (at least some of) the older versions were
> previously fixed.  Please recheck.
> 
> }-- End of excerpt from "Rob Whitlock via gnats"

asterisk16 installs successfully but it lacks a runtime dependency
on bash.

asterisk18 fails to install.

The patch I suggested earlier in [1] was committed for asterisk19
as described in [2], however it contained a faulty fix in that it changed
bash:run to bash. I did that based on a faulty understanding of the
suffixed and unsuffixed forms, as detailed in [3] and verified in [4].
gdt committed the original patch and said in [2] he would commit the
patch to the other asterisk versions but that has not happened. I sent
a patch to correct the bash:run error in [3] but it appears to have been
overlooked.

I am unaware of any other fixes to any of the asterisk packages that are
relevant to this PR.

asterisk21 fails to install.

This assessment is current as of a pkgsrc current that is less than
two hours old.

[1] https://mail-index.netbsd.org/pkgsrc-bugs/2025/06/24/msg074139.html
[2] https://mail-index.netbsd.org/pkgsrc-users/2025/07/08/msg041748.html
[3] https://mail-index.netbsd.org/pkgsrc-users/2025/07/28/msg041807.html
[4] https://mail-index.netbsd.org/pkgsrc-users/2025/07/28/msg041808.html