Re: building asterisk and xmlstarlet

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

> On Jul 8, 2025, at 7:57 AM, Greg Troxel <gdt%lexort.com@localhost> wrote:
> 
> I've applied the patch to asterisk19.

It appears I have misunderstood how USE_TOOLS worked. I thought
that plain bash (without :run) would

- cover the tools case
- and the run case,

and that bash:run would

- not cover the tools case
- but would cover the run case.

It appears that how it actually works is rather the opposite;
bash (without :run)

- only works in the tools case
- and not the run case (as evidenced by the lack of a bash
  dependency in the package)

and bash:run

- works in the tools case (as evidenced by it bringing in
  bash during the build if it is not present)
- works in the run case.

Since the package does in fact require a runtime dependency
on bash, we should reinstate the :run suffix.

Another option is to have both bash and bash:run, but I don't
know whether or not that is superfluous.


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/comms/asterisk19/Makefile,v
retrieving revision 1.44
diff -u -r1.44 Makefile
--- Makefile	8 Jul 2025 11:54:38 -0000	1.44
+++ Makefile	28 Jul 2025 09:02:24 -0000
@@ -32,7 +32,7 @@
 
 .include "../../mk/bsd.prefs.mk"
 
-USE_TOOLS+=		bison gmake perl:run pkg-config tar bash
+USE_TOOLS+=		bison gmake perl:run pkg-config tar bash:run
 USE_LANGUAGES=		c c++
 REPLACE_BASH+=		contrib/scripts/astversion
 REPLACE_BASH+=		contrib/scripts/ast_coredumper