PR/59348 CVS commit: pkgsrc/ham/gnuradio-core

["Greg Troxel" <gdt%netbsd.org@localhost>]

The following reply was made to PR pkg/59348; it has been noted by GNATS.

From: "Greg Troxel" <gdt%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/59348 CVS commit: pkgsrc/ham/gnuradio-core
Date: Sun, 18 May 2025 19:29:32 +0000

 Module Name:	pkgsrc
 Committed By:	gdt
 Date:		Sun May 18 19:29:32 UTC 2025
 
 Modified Files:
 	pkgsrc/ham/gnuradio-core: Makefile Makefile.common buildlink3.mk
 
 Log Message:
 ham/gnuradio-core: Fix C++ language standard issues
 
 gnuradio-core was inexplicably marked as needing C++20, apparently
 because it used to have GCC_REQD=10.  There is no evidence that it
 needs C++20 in upstream docs or CMakeLists, and it builds fine with
 C++17.
 
 Further, GNU Radio's build system does not test for and set --std, so
 it will fail if the compiler defaults to C++11, as can be shown by
 setting FORCE_CXX_STD to C++11.  Therefore, set FORCE_CXX_STD to
 C++17.
 
 Because the installed headers require C++17, also set these variables
 in buildlink3.mk.  FORCE is needed because code that uses GNU Radio
 headers but is otherwise ok with c++11 might set c++11 as the std.
 (Builds have only been working because the default C++ std is high
 enough with gcc10.)
 
 Fixes PR pkg/59348, by causing gcc10 to be used, instead of dragging
 in gcc12.  The osmosdr python is sensitive to gcc mismatch -- but we
 already know such mismatches are UB.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.139 -r1.140 pkgsrc/ham/gnuradio-core/Makefile
 cvs rdiff -u -r1.60 -r1.61 pkgsrc/ham/gnuradio-core/Makefile.common
 cvs rdiff -u -r1.41 -r1.42 pkgsrc/ham/gnuradio-core/buildlink3.mk
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.