pkg/57352: libdeflate: relative library path error building package on macOS

[simmonds%polymorphism.ca@localhost]

>Number:         57352
>Category:       pkg
>Synopsis:       libdeflate: relative library path error building package on macOS
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 14 16:10:00 +0000 2023
>Originator:     Colin Simmonds
>Release:        pkgsrc trunk latest
>Organization:
>Environment:
Darwin macbook.local 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar  6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000 arm64 arm Darwin
>Description:
libdeflate fails to build on macOS if PKG_DEVELOPER= yes

The compile step completes, but it then fails with an error when trying to build the package:

=> Checking for missing run-time search paths in libdeflate-1.10
ERROR: lib/libdeflate.0.dylib: relative library path: libdeflate.0.dylib
ERROR: lib/libdeflate.0.dylib: missing library: libdeflate.0.dylib
*** Error code 1

>How-To-Repeat:
Set PKG_DEVELOPER= yes in mk.conf

$ cd devel/libdeflate
$ bmake
$ bmake install (or update)

>Fix:
The workaround is to set PKG_DEVELOPER= no

More properly, this will need a Makefile change like was done for the same problem with QT5 in http://gnats.netbsd.org/53460