Re: pkg/56627 (net/tigervnc fails to build on Solaris 11.3 due to missing -lsocket -lnsl linker flags)

[Sad Clouds <cryintothebluesky%gmail.com@localhost>]

There is a problem with how this package is configured. I have the
following in my pkg.mk.conf

LOCALBASE=              /opt/pkg
PKG_DBDIR=              ${LOCALBASE}/db/pkg
SYSCONFBASE=            ${LOCALBASE}/etc
VARBASE=                ${LOCALBASE}/var
PKG_TOOLS_BIN=          ${LOCALBASE}/sbin

I'm not a Cmake expert, but seems like something is setting install
directory to /etc/opt/pkg, when it should be /opt/pkg/etc. This
happens for the following 4 files, as seen from install_manifest.txt.

I don't think is Solaris specific. This is probably pkgsrc system
doing something wrong and setting the wrong install directory.

root@pkgsrc:/opt/netbsd/pkg.objects/net/tigervnc/work.pkgsrc/tigervnc-1.12.0# find . -type f | while read i; do grep 'etc\/opt\/pkg' "$i" && echo "^------- $i\n"; done
/etc/opt/pkg/pam.d/tigervnc
/etc/opt/pkg/tigervnc/vncserver-config-defaults
/etc/opt/pkg/tigervnc/vncserver-config-mandatory
/etc/opt/pkg/tigervnc/vncserver.users
^------- ./install_manifest.txt

# 1. Add a user mapping to /etc/opt/pkg/tigervnc/vncserver.users.
^------- ./unix/vncserver/vncserver@.service

$vncSystemConfigDir = "/etc/opt/pkg/tigervnc";
^------- ./unix/vncserver/vncserver

/etc/opt/pkg/tigervnc/vncserver-config-defaults
and then /etc/opt/pkg/tigervnc/vncserver-config-mandatory. None are required to exist.
/etc/opt/pkg/tigervnc/vncserver-config-mandatory
/etc/opt/pkg/tigervnc/vncserver-config-mandatory. The overall configuration file load
order is: /etc/opt/pkg/tigervnc/vncserver-config-defaults, $HOME/.vnc/config, and then
^------- ./unix/vncserver/vncsession.man

   "/etc/opt/pkg/pam.d/tigervnc")
  file(INSTALL DESTINATION "/etc/opt/pkg/pam.d" TYPE FILE RENAME "tigervnc" FILES "/opt/netbsd/pkg.objects/net/tigervnc/work.pkgsrc/tigervnc-1.12.0/unix/vncserver/tigervnc.pam")
   "/etc/opt/pkg/tigervnc/vncserver-config-defaults;/etc/opt/pkg/tigervnc/vncserver-config-mandatory")
  file(INSTALL DESTINATION "/etc/opt/pkg/tigervnc" TYPE FILE FILES
   "/etc/opt/pkg/tigervnc/vncserver.users")
  file(INSTALL DESTINATION "/etc/opt/pkg/tigervnc" TYPE FILE FILES "/opt/netbsd/pkg.objects/net/tigervnc/work.pkgsrc/tigervnc-1.12.0/unix/vncserver/vncserver.users")
^------- ./unix/vncserver/cmake_install.cmake

USERSFILE="/etc/opt/pkg/tigervnc/vncserver.users"
^------- ./unix/vncserver/vncsession-start