Re: PR/56559 CVS commit: pkgsrc/mk/compiler

[manphiz <manphiz%gmail.com@localhost>]

The following reply was made to PR pkg/56559; it has been noted by GNATS.

From: manphiz <manphiz%gmail.com@localhost>
To: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost, 
	gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: PR/56559 CVS commit: pkgsrc/mk/compiler
Date: Thu, 23 Dec 2021 20:29:20 -0800

 On Thu, Dec 23, 2021 at 6:33 AM manphiz <manphiz%gmail.com@localhost> wrote:
 >
 > Actually I replied too early.  It looks like my locally changed
 > Makefile of sudo was still in place when I built the working sudo.
 > Once I reverted that Makefile to the HEAD version, the newly built
 > sudo still crashed with the same memory fault issue.  So it looks like
 > the previous change was not effective, and to make it work my patch to
 > sudo's Makefile is still needed for now.  I'll try to grab a full
 > build log next for a closer look.
 
 Spent some more time on this.  It turns out sudo tries to add RELRO
 related flags on its own[1] which is independent of the general RELRO
 handling provided by pkgsrc.  So I guess my hacky patch for sudo may
 be the way to go in this case as it is specifically needed for mips*
 ports because its default stack size is insufficient.  A more
 full-fledged fix may involve patching GCC to increase default stack
 size for affected archs but that's beyond my understanding.
 
 [1] https://github.com/sudo-project/sudo/blob/main/configure.ac#L4867
 
 >
 > On Thu, Dec 23, 2021 at 3:15 AM manphiz <manphiz%gmail.com@localhost> wrote:
 > >
 > > The following reply was made to PR pkg/56559; it has been noted by GNATS.
 > >
 > > From: manphiz <manphiz%gmail.com@localhost>
 > > To: gnats-bugs%netbsd.org@localhost
 > > Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
 > > Subject: Re: PR/56559 CVS commit: pkgsrc/mk/compiler
 > > Date: Thu, 23 Dec 2021 03:13:38 -0800
 > >
 > >  Thanks Nia!  I have rebuilt sudo on pkgsrc current with your patches
 > >  and verified sudo to be working fine now on Loongson/evbmips n32.
 > >
 > >  I'll open another PR regarding the gnupg2 issue with more info.  Feel
 > >  free to close this one.
 > >