Re: pkg/56444: A new package: textproc/pgFormatter-5.1

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/56444; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/56444: A new package: textproc/pgFormatter-5.1
Date: Wed, 06 Oct 2021 16:45:14 +0200

 nia writes:
 > [...]  
 >  A few nits:
 >  
 >  - "GITHUB_TAG=     refs/tags/v5.1" is not necessary.
 >    It can just be v5.1
 >  - Setting the distname to just v5.1 will conflict with other packages.
 >    It should contain the package name.
 >    Luckily, with github packages, you can set DISTNAME to anything.
 >    Then you can unset DIST_SUBDIR.
 >  - New package names should be all-lowercase.
 >  
 >  Therefore, I would propose:
 >  
 >  GITHUB_PROJECT= pgFormatter
 >  GITHUB_TAG=     v5.1
 >  DISTNAME=       ${GITHUB_PROJECT}-${GITHUB_TAG}
 >  PKGNAME=        ${DISTNAME:S/-v/-/1:tl}
 > [...]  
 
 I have not tested it but I think that's a bit easier to follow
 (rationale same of what you have proposed :)):
 
 DISTNAME=       pgFormatter-5.1
 PKGNAME=        ${DISTNAME:tl}
 GITHUB_PROJECT= pgFormatter
 GITHUB_TAG=     v${PKGVERSION_NOREV}