Re: pkg/56444: A new package: textproc/pgFormatter-5.1

[nia <nia%NetBSD.org@localhost>]

The following reply was made to PR pkg/56444; it has been noted by GNATS.

From: nia <nia%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/56444: A new package: textproc/pgFormatter-5.1
Date: Wed, 6 Oct 2021 14:28:10 +0000

 Thanks for your submission.
 
 A few nits:
 
 - "GITHUB_TAG=     refs/tags/v5.1" is not necessary.
   It can just be v5.1
 - Setting the distname to just v5.1 will conflict with other packages.
   It should contain the package name.
   Luckily, with github packages, you can set DISTNAME to anything.
   Then you can unset DIST_SUBDIR.
 - New package names should be all-lowercase.
 
 Therefore, I would propose:
 
 GITHUB_PROJECT= pgFormatter
 GITHUB_TAG=     v5.1
 DISTNAME=       ${GITHUB_PROJECT}-${GITHUB_TAG}
 PKGNAME=        ${DISTNAME:S/-v/-/1:tl}